feat: Enhance email template, add RG owner tag, scalability input#921
Merged
Conversation
Vamshi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the GitHub Actions Azure deployment workflows by adding a WAF “enable scalability” toggle, improving resource group ownership tagging, and modernizing email notification templates.
Changes:
- Adds an
enable_scalability/ENABLE_SCALABILITYinput and propagates it through the deployment workflow chain to updateinfra/main.parameters.jsonfor WAF deployments. - Ensures resource groups are tagged with
Owner=<github.actor>on create and (best-effort) update. - Reworks notification emails into richer HTML templates and adds HTML-escaping for some injected inputs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/job-send-notifications.yml |
Updates email templates to HTML “pill” status style and adds partial HTML-escaping for inputs. |
.github/workflows/job-deploy-windows.yml |
Adds ENABLE_SCALABILITY input and writes enableScalability into WAF parameters via jq. |
.github/workflows/job-deploy-linux.yml |
Adds ENABLE_SCALABILITY input and writes enableScalability into WAF parameters via jq. |
.github/workflows/job-azure-deploy.yml |
Adds enable_scalability input, sets ENABLE_SCALABILITY, and tags RGs with Owner. |
.github/workflows/deploy-v2.yml |
Adds/validates enable_scalability, refreshes region options, and improves input descriptions. |
.github/workflows/deploy-orchestrator.yml |
Propagates enable_scalability into the reusable deployment workflow. |
.github/workflows/deploy-KMGeneric.yml |
Adds Owner tagging behavior for RG create/update. |
Comments suppressed due to low confidence (3)
.github/workflows/job-send-notifications.yml:450
TEST_SUITE_NAMEis inserted into the HTML email without escaping. Since it can originate from therun_e2e_testsinput, please HTML-escape it (similar to WEBAPP_URL/RESOURCE_GROUP/TEST_REPORT_URL) to avoid injection in the notification body.
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Test Suite</td>
<td style="padding:8px 0; font-size:13px; color:#111827;">${TEST_SUITE_NAME}</td></tr>
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Test Report</td>
<td style="padding:8px 0; font-size:13px;"><a href="${TEST_REPORT_URL}" style="color:#2563eb; text-decoration:none;">📄 View Report</a></td></tr>
.github/workflows/job-send-notifications.yml:539
TEST_SUITE_NAMEis embedded directly into the HTML email body without escaping. Because it can be user-influenced via therun_e2e_testsinput, HTML-escape it to prevent injection in email notifications.
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Test Suite</td>
<td style="padding:8px 0; font-size:13px; color:#111827;">${TEST_SUITE_NAME}</td></tr>
.github/workflows/job-send-notifications.yml:629
TEST_SUITE_NAMEis embedded directly into the HTML email body without escaping. Because it can be user-influenced via therun_e2e_testsinput, HTML-escape it to prevent injection in email notifications.
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Test Suite</td>
<td style="padding:8px 0; font-size:13px; color:#111827;">${TEST_SUITE_NAME}</td></tr>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 21, 2026
Contributor
|
🎉 This PR is included in version 3.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several improvements to the GitHub Actions workflows for Azure deployments. The main changes add support for an "enable scalability" option for WAF deployments, enhance validation and parameter passing for this and other options, and improve resource group tagging. There are also updates to input descriptions for clarity and expanded Azure region choices.
Enable Scalability Feature for WAF Deployments:
enable_scalability(orENABLE_SCALABILITY) input to all relevant workflows (deploy-v2.yml,deploy-orchestrator.yml,job-azure-deploy.yml,job-deploy-linux.yml,job-deploy-windows.yml) to allow toggling scalability features for WAF deployments. This includes input validation, parameter propagation, and updating the deployment parameters with the chosen value. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Resource Group Tagging Improvements:
Ownertag with the GitHub actor, both when creating a new resource group and when deploying to an existing one. This improves resource tracking and ownership clarity. [1] [2]Input Description and Validation Enhancements:
trueorfalsevalues and providing clear error messages when validation fails. [1] [2] [3]Azure Region Options Update:
Parameter Passing and Workflow Consistency:
These changes collectively enhance the flexibility, clarity, and maintainability of the deployment workflows.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information